Skip to content

Cleanup appcheck branch for merge #4834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2021
Merged

Cleanup appcheck branch for merge #4834

merged 3 commits into from
Apr 27, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Apr 26, 2021 •
edited
Loading

  • Checked that packages are set to private.
  • Remove EAP packaging changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: d3db148

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 force-pushed the ch-appcheck-feature branch from 0568ba5 to b15a4ee Compare April 27, 2021 18:43
@hsubox76 hsubox76 force-pushed the ch-appcheck-merge-changes branch from 55d3faf to 189991b Compare April 27, 2021 21:04
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (b15a4ee) Head (b53edaa) Diff
    esm2017 ? 18.7 kB ? (?)
    main ? 24.2 kB ? (?)
    module ? 23.4 kB ? (?)

  • @firebase/api-documenter

    Type Base (b15a4ee) Head (b53edaa) Diff
    main ? 3.72 kB ? (?)

  • @firebase/app

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 10.8 kB ? (?)
    esm2017 ? 9.57 kB ? (?)
    lite ? 8.88 kB ? (?)
    lite-esm2017 ? 7.87 kB ? (?)
    main ? 9.93 kB ? (?)
    module ? 10.8 kB ? (?)
    react-native ? 9.64 kB ? (?)

  • @firebase/auth

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 181 kB ? (?)
    main ? 181 kB ? (?)
    module ? 181 kB ? (?)

  • @firebase/component

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 7.24 kB ? (?)
    esm2017 ? 5.55 kB ? (?)
    main ? 7.57 kB ? (?)
    module ? 7.24 kB ? (?)

  • @firebase/database

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 296 kB ? (?)
    esm2017 ? 265 kB ? (?)
    main ? 298 kB ? (?)
    module ? 296 kB ? (?)

  • @firebase/database-compat

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 86.3 kB ? (?)
    main ? 102 kB ? (?)
    module ? 86.3 kB ? (?)

  • @firebase/database-exp

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 246 kB ? (?)
    main ? 278 kB ? (?)
    module ? 246 kB ? (?)

  • @firebase/firestore

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 283 kB ? (?)
    esm2017 ? 225 kB ? (?)
    main ? 529 kB ? (?)
    module ? 283 kB ? (?)
    react-native ? 225 kB ? (?)

  • @firebase/firestore-compat

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 28.4 kB ? (?)
    main ? 37.4 kB ? (?)
    module ? 28.4 kB ? (?)
    react-native ? 28.1 kB ? (?)

  • @firebase/firestore-exp

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 223 kB ? (?)
    main ? 505 kB ? (?)
    module ? 223 kB ? (?)
    react-native ? 223 kB ? (?)

  • @firebase/firestore-lite

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 71.4 kB ? (?)
    main ? 145 kB ? (?)
    module ? 71.4 kB ? (?)
    react-native ? 71.6 kB ? (?)

  • @firebase/firestore/bundle

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 289 kB ? (?)
    esm2017 ? 175 kB ? (?)
    main ? 525 kB ? (?)
    module ? 289 kB ? (?)
    react-native ? 175 kB ? (?)

  • @firebase/firestore/memory

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 215 kB ? (?)
    esm2017 ? 171 kB ? (?)
    main ? 323 kB ? (?)
    module ? 215 kB ? (?)
    react-native ? 171 kB ? (?)

  • @firebase/firestore/memory-bundle

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 223 kB ? (?)
    esm2017 ? 175 kB ? (?)
    main ? 320 kB ? (?)
    module ? 223 kB ? (?)
    react-native ? 175 kB ? (?)

  • @firebase/functions

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 10.6 kB ? (?)
    esm2017 ? 8.15 kB ? (?)
    main ? 11.0 kB ? (?)
    module ? 10.6 kB ? (?)

  • @firebase/installations

    Type Base (b15a4ee) Head (b53edaa) Diff
    esm2017 ? 16.6 kB ? (?)
    main ? 22.2 kB ? (?)
    module ? 21.6 kB ? (?)

  • @firebase/logger

    Type Base (b15a4ee) Head (b53edaa) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.38 kB ? (?)
    module ? 4.65 kB ? (?)

  • @firebase/messaging

    Type Base (b15a4ee) Head (b53edaa) Diff
    esm2017 ? 26.2 kB ? (?)
    main ? 34.9 kB ? (?)
    module ? 34.4 kB ? (?)

  • @firebase/performance

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 27.7 kB ? (?)
    esm2017 ? 25.9 kB ? (?)
    main ? 28.0 kB ? (?)
    module ? 27.7 kB ? (?)

  • @firebase/polyfill

    Type Base (b15a4ee) Head (b53edaa) Diff
    main ? 747 B ? (?)
    module ? 705 B ? (?)

  • @firebase/remote-config

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 22.4 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 23.0 kB ? (?)
    module ? 22.4 kB ? (?)

  • @firebase/rules-unit-testing

    Type Base (b15a4ee) Head (b53edaa) Diff
    main ? 12.6 kB ? (?)

  • @firebase/storage

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 63.4 kB ? (?)
    esm2017 ? 54.6 kB ? (?)
    main ? 63.8 kB ? (?)
    module ? 63.4 kB ? (?)

  • @firebase/storage-compat

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 10.2 kB ? (?)
    main ? 29.1 kB ? (?)
    module ? 10.2 kB ? (?)

  • @firebase/storage-exp

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 51.5 kB ? (?)
    main ? 52.6 kB ? (?)
    module ? 51.5 kB ? (?)

  • @firebase/util

    Type Base (b15a4ee) Head (b53edaa) Diff
    browser ? 20.2 kB ? (?)
    esm2017 ? 19.0 kB ? (?)
    main ? 24.6 kB ? (?)
    module ? 20.2 kB ? (?)

  • @firebase/webchannel-wrapper

    Type Base (b15a4ee) Head (b53edaa) Diff
    esm2017 ? 39.5 kB ? (?)
    main ? 46.9 kB ? (?)
    module ? 40.8 kB ? (?)

  • firebase

    Click to show 15 binary size changes.
    Type Base (b15a4ee) Head (b53edaa) Diff
    firebase-analytics.js ? 35.8 kB ? (?)
    firebase-app.js ? 21.2 kB ? (?)
    firebase-auth.js ? 177 kB ? (?)
    firebase-database.js ? 186 kB ? (?)
    firebase-firestore.js ? 327 kB ? (?)
    firebase-firestore.memory.js ? 262 kB ? (?)
    firebase-functions.js ? 10.7 kB ? (?)
    firebase-installations.js ? 19.3 kB ? (?)
    firebase-messaging.js ? 41.0 kB ? (?)
    firebase-performance-standalone.es2017.js ? 72.9 kB ? (?)
    firebase-performance-standalone.js ? 49.2 kB ? (?)
    firebase-performance.js ? 38.3 kB ? (?)
    firebase-remote-config.js ? 36.9 kB ? (?)
    firebase-storage.js ? 41.6 kB ? (?)
    firebase.js ? 873 kB ? (?)

Test Logs

@hsubox76 hsubox76 merged commit 770fdf9 into ch-appcheck-feature Apr 27, 2021
@hsubox76 hsubox76 deleted the ch-appcheck-merge-changes branch April 27, 2021 22:25
@firebase firebase locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@jsdt jsdt Awaiting requested review from jsdt

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @Feiyang1